Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keithley 2600: Add list to hold channels #1603

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

neildick
Copy link
Contributor

Add a list to the instrument class to make referencing the
channels easier

Changes proposed in this pull request:

  • Add list to hold channels

Hey @jenshnielsen
I like to be able to loop over the channels for initialization etc, so adding a simple list to this driver.

Thanks

Neil Dick and others added 2 commits June 20, 2019 17:25
Add a list to the instrument class to make referencing the
channels easier
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1603 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1603   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files         116      116           
  Lines       12416    12416           
=======================================
  Hits         8961     8961           
  Misses       3455     3455

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look ok to me.

@jenshnielsen jenshnielsen merged commit e098bfc into microsoft:master Jun 20, 2019
giulioungaretti pushed a commit that referenced this pull request Jun 20, 2019
Merge: 22b6d88 4136f22
Author: Jens Hedegaard Nielsen <Jens.Nielsen@microsoft.com>

    Merge pull request #1603 from neildick/feature/2600_channel_list
@neildick neildick deleted the feature/2600_channel_list branch June 20, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants