Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keysight B1500 Parameter Analyzer: Sampling measurement mode #1607

Merged
merged 102 commits into from
Aug 22, 2019

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Jun 20, 2019

Implement Sampling measurement mode for Keysight B1500 Semiconductor Parameter Analyzer and its B1517A SMU (Source/Monitor Unit) module. This is very useful, for example, for measuring voltage noise in the pinchoff region for a device and calculate its power spectral density.

Includes:

  • ParameterWithSetpoints that represents the sampling measurement
  • parser for basic ASCII FMT 1
  • parser for binary format that contains timestamps of the measurement points ("won't do" because parsing that binary format is not worth the effort)
  • document Sampling mode measurement in the example notebook
  • B1517A.timing_parameters method corresponding to MT FLEX command for settings timing parameters of sampling measurement
  • B1517A.measurement_mode parameter that wraps MM FLEX command
  • B1500.use_manual_mode_for_high_speed_adc convenience function that is useful in the context of sampling mode measurement
  • docstrings and tests for some relevant commands represented as methods of MessageBuilder

@astafan8 astafan8 self-assigned this Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1607 into master will increase coverage by 0.25%.
The diff coverage is 93.7%.

@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
+ Coverage   66.97%   67.23%   +0.25%     
==========================================
  Files         144      145       +1     
  Lines       17813    17938     +125     
==========================================
+ Hits        11931    12060     +129     
+ Misses       5882     5878       -4

astafan8 and others added 22 commits July 15, 2019 09:27
Only changed observed in file was that it was running on python 3 kernel
…ent time

Also edit compliance method inside SamplingMeasurement class to return a
list. Value of list is 1 if compliance is met else it is zero. If
compliance is not met error message is displayed.
If no timing parameters are found tell user to 'set timing parameters first'
@lakhotiaharshit lakhotiaharshit marked this pull request as ready for review August 21, 2019 12:06
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few style suggestions inline. Overall I think this looks good

Copy link
Contributor Author

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Once CI passes, I'll merge! Great work!

@astafan8 astafan8 merged commit 99f543d into microsoft:master Aug 22, 2019
@astafan8 astafan8 deleted the b1500-sampling branch August 22, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants