-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keysight B1500 Parameter Analyzer: Sampling measurement mode #1607
Conversation
Useful for Sampling measurement.
Codecov Report
@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
+ Coverage 66.97% 67.23% +0.25%
==========================================
Files 144 145 +1
Lines 17813 17938 +125
==========================================
+ Hits 11931 12060 +129
+ Misses 5882 5878 -4 |
Only changed observed in file was that it was running on python 3 kernel
…ment data and indices
…ined from _get_sample_number function
…ent time Also edit compliance method inside SamplingMeasurement class to return a list. Value of list is 1 if compliance is met else it is zero. If compliance is not met error message is displayed.
If no timing parameters are found tell user to 'set timing parameters first'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few style suggestions inline. Overall I think this looks good
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_sampling_measurement.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_sampling_measurement.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_sampling_measurement.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1517A.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1517A.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_module.py
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_module.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_sampling_measurement.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_sampling_measurement.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_sampling_measurement.py
Outdated
Show resolved
Hide resolved
qcodes/tests/drivers/keysight_b1500/b1500_driver_tests/test_sampling_measurement.py
Outdated
Show resolved
Hide resolved
…mpling_measurement.py Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
…nto b1500-sampling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Once CI passes, I'll merge! Great work!
Implement Sampling measurement mode for Keysight B1500 Semiconductor Parameter Analyzer and its B1517A SMU (Source/Monitor Unit) module. This is very useful, for example, for measuring voltage noise in the pinchoff region for a device and calculate its power spectral density.
Includes:
ParameterWithSetpoints
that represents the sampling measurementFMT 1
parser for binary format that contains timestamps of the measurement points("won't do" because parsing that binary format is not worth the effort)B1517A.timing_parameters
method corresponding toMT
FLEX command for settings timing parameters of sampling measurementB1517A.measurement_mode
parameter that wrapsMM
FLEX commandB1500.use_manual_mode_for_high_speed_adc
convenience function that is useful in the context of sampling mode measurementMessageBuilder