Explicit experiment in notebooks #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
+ Coverage 70.48% 70.48% +<.01%
==========================================
Files 123 123
Lines 14870 14871 +1
==========================================
+ Hits 10481 10482 +1
Misses 4389 4389 |
astafan8
reviewed
Jun 21, 2019
docs/examples/DataSet/Pedestrian example of subscribing to a DataSet.ipynb
Outdated
Show resolved
Hide resolved
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
|
@astafan8 All suggestions should have been addressed. I can no longer reproduce the subscription issue, but that is in any case not specific to this branch |
astafan8
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a bunch of notebooks to use an explicit experiment. Along the way make it possible to pass an experiment when loading legacy data.
There are a lot of other improvements that could be made to these notebooks. These are explicitly out of scope for this pr.
The doND notebook has not been updated. This needs an active experiment to make any sense