Add plot_dataset method #1614
Merged
Add plot_dataset method #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
dataset_direct_plot
branch
from
2a31775
to
c6b9e4a
Compare
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
also reorg and fix a few more mentions of plot_by_id that really should be plot_dataset now
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
+ Coverage 70.48% 70.49% +<.01%
==========================================
Files 123 123
Lines 14871 14873 +2
==========================================
+ Hits 10482 10484 +2
Misses 4389 4389 |
astafan8
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make plot by id uses this under the hood. There seems to be no good reason why you
need to supply the
run_idto plot if you already have a loaded dataset. So refactor the code a bit to makeit possible to directly plot a dataset.