Add a method on the channel parameter to check if it is closed. #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
reviewed
Jul 2, 2019
added 2 commits
July 2, 2019 14:31
…ations: `test_is_closed` should be run before opening/closing channels on the mock instrument.
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
=======================================
Coverage 70.55% 70.55%
=======================================
Files 123 123
Lines 14921 14921
=======================================
Hits 10528 10528
Misses 4393 4393 |
please do not depend on the order the tests are executed. this is so annoying to debug if there are problems (and in fact we recently had such an experience). just prepare the insturment in the correct state in the test (or in a separate fixture), and then test the method. |
added 2 commits
July 5, 2019 10:00
…d "close" with lower case string, while the yaml file contains handlers for upper case. This causes the mock instrument to return "ERROR" after the test 'test_locking_mechanism'. This has gone unnoticed for a long time because there were no test after 'test_locking mechanism'. @mikhail Astafev: You were right mate, to call me out on this. It caused me to find a bug :-)
|
@astafan8 can you have another look at this, please? |
astafan8
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to check if a channel on the Keithley S46 is closed we have to write the following:
This can be error prone: typos can cause this code to fail (e.g. 'closed' instead of 'close', 'Close' with a capital C, accidental spaces, etc).
Furthermore, a bug of this nature can go unnoticed for a long time and might be hard to track down, as the code above will not generate an exception when 'close' is spelled wrong.
The following code is much more robust
An understandable error message will be thrown when the above code is run with a typo in the method name.