Feature : an elapsed time parameter #1629
Conversation
WilliamHPNielsen
force-pushed
the
feature/time_parameter
branch
from
dd72ac7
to
d7b4260
Compare
|
I realise that some users might like to have a parameter to measure more absolute time (time stamps). I think that is beyond the scope of this PR. |
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
+ Coverage 66.55% 66.58% +0.03%
==========================================
Files 140 141 +1
Lines 17389 17406 +17
==========================================
+ Hits 11573 11590 +17
Misses 5816 5816 |
| "from qcodes.utils.time import ElapsedTimeParameter\n", | ||
| "from qcodes.instrument.parameter import Parameter\n", | ||
| "from qcodes.dataset.measurements import Measurement\n", | ||
| "from qcodes.dataset.sqlite.database import initialise_or_create_database_at\n", |
There was a problem hiding this comment.
i'm not yet comfortable with exposing where this function comes from. i prefer that for now it comes just from qcodes., otherwise people will start looking into what else they can use from .sqlite.* while they are not allowed because it's all our internal stuff that can change, etc.
There was a problem hiding this comment.
I have moved one import to resolve this. We should make a separate PR that attacks the mess of the qcodes namespace.
| "source": [ | ||
| "# Measuring X as a function of time\n", | ||
| "\n", | ||
| "Sometimes we'd like to measure something as a function of elapsed wall clock time. This notebook provides a simple example of doing that using the `ElapsedTimeParameter`." |
There was a problem hiding this comment.
I'd recommend to add here the reason behind ElapsedTimeParameter - the fact that qcodes provides it, hence all qcodes users in principle can use the same parameter which makes it easier to relate measurements which use this parameter (sorry, on friday evening my language skills are gone, but i hope you got what i mean :) )
There was a problem hiding this comment.
I have added a little bit. I'm not too sure what you are after... -do we need to document why standardization is helpful?
There was a problem hiding this comment.
yes, in a subtle way, like "this parameter provides a single way of measuring time which is awesome because standardization is awesome in this case" :)
|
After discussions with Jens, I have moved the code from |
WilliamHPNielsen
force-pushed
the
feature/time_parameter
branch
from
7552629
to
6cb9712
Compare
|
I think we should include this in the api docs in docs/api/parameter/* Just let me know if you need a hand setting that up correctly |
|
@jenshnielsen was this what you had in mind? |
There has been recurring requests to get a default QCoDeS parameter to measure elapsed wall clock time in an experiment. This PR introduces a simple
ElapsedTimeParameterto conveniently measure - you guessed it - elapsed wall clock time.Changes proposed in this pull request:
@QCoDeS/core