-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base Sphinx makefiles on the modern template #1636
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
- Coverage 66.59% 66.58% -0.01%
==========================================
Files 141 141
Lines 17406 17406
==========================================
- Hits 11591 11590 -1
- Misses 5815 5816 +1 |
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
=======================================
Coverage 66.58% 66.58%
=======================================
Files 141 141
Lines 17406 17406
=======================================
Hits 11590 11590
Misses 5816 5816 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat!
Could you add a link somewhere to the docs where this new way of interacting with sphinx is explained? please :)
@astafan8 I am not sure what you mean. Functionally there should be no big change. It is mainly that instead of having all these exilic targets on the line of |
@jenshnielsen ah, got it now, thanks! |
This significantly reduces the amount of boilerplate code in the makefiles and should hopefully make the logic a bit easier to follow