Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Sphinx makefiles on the modern template #1636

Merged
merged 4 commits into from
Jul 23, 2019

Conversation

jenshnielsen
Copy link
Collaborator

This significantly reduces the amount of boilerplate code in the makefiles and should hopefully make the logic a bit easier to follow

docs/Makefile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #1636 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
- Coverage   66.59%   66.58%   -0.01%     
==========================================
  Files         141      141              
  Lines       17406    17406              
==========================================
- Hits        11591    11590       -1     
- Misses       5815     5816       +1

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #1636 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   66.58%   66.58%           
=======================================
  Files         141      141           
  Lines       17406    17406           
=======================================
  Hits        11590    11590           
  Misses       5816     5816

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

Could you add a link somewhere to the docs where this new way of interacting with sphinx is explained? please :)

@jenshnielsen
Copy link
Collaborator Author

@astafan8 I am not sure what you mean. Functionally there should be no big change. It is mainly that instead of having all these exilic targets on the line of target foo: call sphinx build with arg foo there is just a default target

@astafan8
Copy link
Contributor

@jenshnielsen ah, got it now, thanks!

@jenshnielsen jenshnielsen merged commit b9261c4 into microsoft:master Jul 23, 2019
@jenshnielsen jenshnielsen deleted the modern_sphinx branch July 23, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants