Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture run and counter to new columns #1637

Merged
merged 69 commits into from
Jul 23, 2019
Merged

Capture run and counter to new columns #1637

merged 69 commits into from
Jul 23, 2019

Conversation

jenshnielsen
Copy link
Collaborator

Replaces #1605

@jenshnielsen
Add captured_run_id with matching upgrade
46a7e70
@jenshnielsen
Add missing new line
cad2646
@jenshnielsen
Prototype of query to look up all guids matching a specific
130fc16 
captured run_id
@jenshnielsen
Typos
bde72ae
@jenshnielsen
Wip preservation of capture_run_id in export
a9eef13
@jenshnielsen
Add wip function to load data from metadata
f0de9dc
@jenshnielsen
Add minimal example of loading data from captured_run_id
9ac950e
@jenshnielsen
Rerun notebook with bugfixes
9591fa6
@jenshnielsen
Update method names
11127fb
@jenshnielsen
Update notebook to reflect changes
b0221bd
@jenshnielsen
captured_run_id is also a persisted trait. Treat it as such
4e75c44
@jenshnielsen
Temp checkout v6 branch
9c5176a 
To be reverted once this is merged
@jenshnielsen
Generate v6 dbs
47df178
@jenshnielsen
update docstring
8d40bdc
@jenshnielsen
Test upgrade from 6 to 7
f47d928
@jenshnielsen
Add tabulate as a requirement
f239b58
@jenshnielsen
fix wrong types
2f4b508
@jenshnielsen
Add test that datasets can be reloaded after being inserted in
82b0d6e 
random order with overlapping run_ids
@jenshnielsen
Add better api docs
7bbf6c1
@jenshnielsen
Make helper function generate table without printing for easier testing
d595a4b
@jenshnielsen
Correct typo in docstring of test helper method
8b3bf2d
@jenshnielsen
Extend upgrade test to also make sure that captured_run_ids are assigned
05d08c0 
post upgrade
@jenshnielsen
Add tests that data table is as expected.
dea24d2
@jenshnielsen
Add note about potentially splitting tests
8991699
@jenshnielsen
Correct order of header
53862e7
@jenshnielsen
Create runs in the correct file
4884eb6
@jenshnielsen
Split filter_guids out into it's own function
c27dd08
@jenshnielsen
move filter to a better loc
7a72a42
@jenshnielsen
Add tests for guid filtering
7e1c3c6
@jenshnielsen
Remove double import
021f803
jenshnielsen and others added 18 commits July 23, 2019 10:02
@jenshnielsen
Testing that counters increment as expected
08b3794
@jenshnielsen
Increment captured counters from maximum values
2399ee3
@jenshnielsen
Update error messages
7bab591
@jenshnielsen
Test the case of no matching runs
5a27751
@jenshnielsen
Correct column name
9f1d4f2
@jenshnielsen
Restrict test further
42949e0
@jenshnielsen
Fix running with latest mypy
1e43769
@jenshnielsen
add load_by_run_spec to top namespace
8407bbb
@jenshnielsen
Update docstring
2c455af
@jenshnielsen
Use explicit conn in tests and test handling of non existing exp
06b6b27
@jenshnielsen
import load_by_guid in the toplevel namespace
5af4404
@jenshnielsen
Use captured_run_id for plot title
ba259e5
@jenshnielsen
use load_by_run_spec rather than load_by_id for plotting
22ff782
@WilliamHPNielsen @jenshnielsen
Expand text in notebook
9b8f3ca
@WilliamHPNielsen @jenshnielsen
Ignore unused import for test fixture
01788de
@WilliamHPNielsen @jenshnielsen
Add small improvements to comments and docsstrings
3495fb2
@jenshnielsen
Add notes on loading data to context manager notebook
939d7e3
@jenshnielsen
Add counter to db table
9fc8f91
@jenshnielsen jenshnielsen mentioned this pull request Jul 23, 2019
Closed
3 tasks
astafan8
astafan8 reviewed Jul 23, 2019
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! Thanks for the docs!!!

qcodes/dataset/plotting.py Show resolved Hide resolved
qcodes/dataset/sqlite/db_upgrades/__init__.py Outdated Show resolved Hide resolved
qcodes/dataset/sqlite/queries.py Show resolved Hide resolved
qcodes/tests/dataset/test_database_creation_and_upgrading.py Show resolved Hide resolved
qcodes/tests/dataset/test_database_creation_and_upgrading.py Show resolved Hide resolved
@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Jul 23, 2019 •
edited

@astafan8 I think this should address all your comments

@jenshnielsen jenshnielsen merged commit d651e3d into microsoft:db_upgrades Jul 23, 2019
@WilliamHPNielsen WilliamHPNielsen mentioned this pull request Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @astafan8 @WilliamHPNielsen