update m4i docstrings #1638
Merged
update m4i docstrings #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Jul 23, 2019
|
@peendebak please fix the codacy things, and then i'll merge. |
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
==========================================
+ Coverage 66.58% 66.58% +<.01%
==========================================
Files 141 141
Lines 17406 17406
==========================================
+ Hits 11589 11590 +1
+ Misses 5817 5816 -1 |
added 2 commits
July 23, 2019 12:05
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The m4i acquisition methods do not all set properties for the triggering in the same way. Fixing this would be backwards incompatible. This PR at least updates some of the docstrings.
@astafan8