Use mypy 0.720 #1640
Merged
Use mypy 0.720 #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
mypy_update
branch
from
57752ce
to
07c96f0
Compare
jenshnielsen
force-pushed
the
mypy_update
branch
from
07c96f0
to
5d51ee0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 66.92% 66.93% +<.01%
==========================================
Files 142 142
Lines 17586 17591 +5
==========================================
+ Hits 11770 11775 +5
Misses 5816 5816 |
| @@ -182,30 +182,32 @@ def plot_dataset(dataset: DataSet, | |||
| nplots = len(alldata) | |||
|
|
|||
| if isinstance(axes, matplotlib.axes.Axes): | |||
| axes = [axes] | |||
| axeslist = [axes] | |||
There was a problem hiding this comment.
I like the way mypy thinks :) Readability +1
astafan8
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely to trigger a few errors so mark it wip for now