Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added instrument paramater snapshot_exclude #1653

Merged

Conversation

nyxus
Copy link
Contributor

@nyxus nyxus commented Aug 2, 2019

Changes proposed in this pull request:

  • Added a parameter to the instrument parameter to exclude it from the snapshot.

Note that this is very similar to #1651, the goal is the same but it has a different implementation. To see the reason why we need this please look at #1651 which has a detailed problem description. This implementation was suggested by @jenshnielsen, which uses the instrument parameter to store the snapshot_exclude instead of providing a list to the snapshot function.

@jenshnielsen, @AdriaanRol

@nyxus
Copy link
Contributor Author

nyxus commented Aug 2, 2019

Note that I still need to add tests.

@nyxus nyxus changed the title Feature: Instrument paramater to exclude from the snapshot Feature: Added instrument paramater snapshot_exclude Aug 2, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1653 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
+ Coverage   67.07%   67.08%   +<.01%     
==========================================
  Files         144      144              
  Lines       17679    17686       +7     
==========================================
+ Hits        11858    11864       +6     
- Misses       5821     5822       +1

@nyxus
Copy link
Contributor Author

nyxus commented Aug 5, 2019

I've added tests and also tested the new implementation on a device on my desk. Can someone review and merge the code? @jenshnielsen, @WilliamHPNielsen?

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few comments inline. In addition it seems like some of the lines are more than 80 char l Could you check this

qcodes/tests/test_snapshot.py Show resolved Hide resolved
@nyxus
Copy link
Contributor Author

nyxus commented Aug 5, 2019

I've adapted the code after review and fixed the line length issues.

@jenshnielsen
Copy link
Collaborator

Looks good. I will leave this for a bit to givee others a chance to merge

@jenshnielsen jenshnielsen merged commit 6cc5c2e into microsoft:master Aug 7, 2019
@nyxus nyxus deleted the InstrumentParameterSnapshotExclude branch August 8, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants