Add functionalities to dpo measurement #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 2, 2019 16:26
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
+ Coverage 67.01% 67.04% +0.03%
==========================================
Files 143 143
Lines 17645 17677 +32
==========================================
+ Hits 11825 11852 +27
- Misses 5820 5825 +5 |
jenshnielsen
approved these changes
Aug 6, 2019
| "time_constant", | ||
| get_cmd="MEASUrement:STATIstics:WEIghting?", | ||
| set_cmd="MEASUrement:STATIstics:WEIghting {}", | ||
| get_parser=int |
There was a problem hiding this comment.
It's not obvious to me how this works. Would it make sense to include a docstring for this parameter?
added 2 commits
August 6, 2019 11:28
…nctionalities_to_dpo_measurement
|
@jenshnielsen, I think I have addressed your comment. Can you merge this PR if there are no further issues? |
jenshnielsen
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the following functionalities to the measurement submodule of the driver:
stateto True)@astafan8 Can you have a look, please?