Add logging line to measurement #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Aug 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
=========================================
+ Coverage 67.1% 67.1% +<.01%
=========================================
Files 144 144
Lines 17759 17760 +1
=========================================
+ Hits 11917 11918 +1
Misses 5842 5842 |
|
@astafan8 It's not completely clear where the completion logging should happen, but probably in the dataset as the dataset is marked complete. Exceptions are already caught by the logging. |
jenshnielsen
pushed a commit
that referenced
this pull request
Aug 19, 2019
…ne_to_measurement Add logging line to measurement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very natural thing to log; that a measurement started.
@QCoDeS/core