Fix 3.6 wheels by always depending on dataclasses #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
fix_wheel_generation
branch
from
1cedbe8
to
e3e7bb9
Compare
WilliamHPNielsen
approved these changes
Aug 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
=======================================
Coverage 66.94% 66.94%
=======================================
Files 144 144
Lines 17807 17807
=======================================
Hits 11921 11921
Misses 5886 5886 |
jenshnielsen
added a commit
that referenced
this pull request
Aug 19, 2019
Fix 3.6 wheels by always depending on dataclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unconditionally install dataclasses but python 3.7 will normally prefer the std lib version over the site-package as site-packages is later in the path than the standard library