Improve requirements #1686
Merged
Improve requirements #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenshnielsen
commented
Aug 27, 2019
jenshnielsen
commented
- Add env markers for dataclasses in requirements.txt
- Matplotlib is a non optional dependency by now so add it to setup.py
- Add websockets to requirements.txt to align requirements.txt with setup.py
Along with a specific websockets version
matplotlib is no longer an optional dependency
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
+ Coverage 67.23% 67.23% +<.01%
==========================================
Files 145 145
Lines 17938 17938
==========================================
+ Hits 12060 12061 +1
+ Misses 5878 5877 -1 |
astafan8
approved these changes
Aug 29, 2019
| @@ -12,6 +12,7 @@ broadbean>=0.9.1 | |||
| wrapt | |||
| pandas | |||
| tqdm | |||
| dataclasses # this won't be needed when we move to python 3.7 | |||
| dataclasses;python_version<'3.7' # this won't be needed when we move to python 3.7 | |||
| websockets==8.0.2 | |||
There was a problem hiding this comment.
does this need to be reflected in environment.yaml ?
There was a problem hiding this comment.
Yes I think we should pin it there too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.