-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Infiniium.py: add option to save waveform to usb #1716
Conversation
Adding a basic function save_data for saving displayed waveforms as a data list, and an accompanying parameter data_format for setting the format to save it in.
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
=======================================
Coverage 70.38% 70.38%
=======================================
Files 152 152
Lines 18859 18859
=======================================
Hits 13274 13274
Misses 5585 5585 |
@pjramsey37 Did you close this on purpose? |
@jenshnielsen Yes, but I guess maybe I shouldn't have done? I have no clue what a pull request is - I created it because I couldn't work out how to edit my submission and that was the only way I could see to alert someone else to the mistake I'd left in the code, and I figured now it was fixed I have no further need of it. |
I think we should reopen this PR, then, shouldn't we? |
@pjramsey37 when looking at the diff of the file, there's a menu on the right where you can choose to "edit file". You could also work locally using your own fork of qcodes instead of using github for that (if this didn't make any sense to you, i suggest to read some tutorials about back to the initial purpose of the PR:
@pjramsey37 is the PR still relevant? if yes, then let's make sure that all the tests pass and there are no typos or mistakes code-wise, and after that let's merge it, so that other users can benefit from your contribution :) |
@pjramsey37 is this change still needed? we haven't heard from you for a while... If it still is, let's merge, otherwise I will close. |
@astafan8 Sorry. When my job ended I just gave up on sorting this since I couldn't see how to fix the merging issues. I'm hoping I've now fixed the issues which prevented merging (which mostly related to line length). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjramsey37 great! thank you! then i'll take care of merging it and fixing necessary formatting things.
Adding a basic function save_data for saving displayed waveforms as a data list, and an accompanying parameter data_format for setting the format to save it in.
Fixes #issuenumber.
Changes proposed in this pull request:
@mention one core developer