Make DataSet.paramspecs always return ParamSpec's #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... not ParamSpecBase's This was introduced some time ago when parameter info was not written to database until the dataset is started. This is an interface inconsistency, originally this DataSet property was returning ParamSpec's.
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
+ Coverage 67.22% 67.31% +0.09%
==========================================
Files 146 146
Lines 18005 18074 +69
==========================================
+ Hits 12103 12167 +64
- Misses 5902 5907 +5 |
WilliamHPNielsen
approved these changes
Sep 18, 2019
jenshnielsen
deleted the
dataset-paramspecs-to-return-paramspecs-only
branch
|
@astafan8 Is there any reason that you created this feature branch on qcodes/qcodes and not on your fork? |
@jenshnielsen mostly out of laziness, i made the change using the github website. and after merging i always delete these branches (thanks for doing that for me now). |
|
Ok that's fine as long as you are sure that you remember to delete the branch. I know from previous experience that it's easy to forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... not ParamSpecBase's.
This was introduced some time ago when parameter info
was not written to database until the dataset is started.
This is an interface inconsistency, originally this DataSet
property was returning ParamSpec's.