Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on python 3.8 #1722

Merged
merged 9 commits into from
Sep 17, 2019
Merged

Testing on python 3.8 #1722

merged 9 commits into from
Sep 17, 2019

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Sep 16, 2019

Since its scheduled for release soon
There are a few outstanding questions.

  • Most packages are not available as wheels yet so add a bunch of dependencies to build from source. This does initially take more time but caching should take care of this in the following builds.
  • Pyqt5 is not available from pypi as whl or as source so skip it completely for 3.8
  • Some docs examples require pyqt5 so skip building the docs for 3.8 for now
  • There are a bunch of new deprecation warnings. I am planing on fixing these in a new pr

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #1722 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1722     +/-   ##
=========================================
+ Coverage   67.21%   67.32%   +0.1%     
=========================================
  Files         146      146             
  Lines       18001    18073     +72     
=========================================
+ Hits        12100    12167     +67     
- Misses       5901     5906      +5

@jenshnielsen jenshnielsen merged commit 70fe9d3 into microsoft:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants