Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up warnings triggered by python 3.8 #1723

Merged
merged 6 commits into from
Sep 25, 2019

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Sep 17, 2019

This cleans up new warnings triggered by python 3.8

  • Don't use is to compare against string literals
  • Don't use deprecated and unused encoding kwarg for json.loads. This has been unused since 3.1
  • Stop using deprecated @coroutine decorator
  • Remove pre python 3.5 workarounds in coroutine tests

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1723 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1723   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files         146      146           
  Lines       18072    18072           
=======================================
  Hits        12165    12165           
  Misses       5907     5907

@jenshnielsen jenshnielsen changed the title Start cleaning up warnings triggered by python 3.8 Clean up warnings triggered by python 3.8 Sep 17, 2019
@jenshnielsen
Copy link
Collaborator Author

There are still a number of warnings. They are as far as I can see triggered from dependencies and will hopefully be resolved upstream soon.

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! About time we drop support for pre-py3.5 syntax :)

@jenshnielsen jenshnielsen merged commit 14bd854 into microsoft:master Sep 25, 2019
@jenshnielsen jenshnielsen deleted the 38warnings branch September 25, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants