Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Mypy 0.730 #1738

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Use Mypy 0.730 #1738

merged 2 commits into from
Sep 27, 2019

Conversation

jenshnielsen
Copy link
Collaborator

This allows us to restrict ignore comments to only specific error codes.

This has 2 benefits imho:

  • We don't ignore any other errors than we should
  • This self documents why we need the ignore statements.

For earlier versions of mypy this is simply ignored.

astafan8
astafan8 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$%^&$%^&$% LOVE IT !!! :)

@jenshnielsen
Copy link
Collaborator Author

For reference the error codes are given here https://mypy.readthedocs.io/en/latest/error_codes.html

@jenshnielsen jenshnielsen merged commit 3c345f7 into microsoft:master Sep 27, 2019
@jenshnielsen jenshnielsen deleted the mypy730 branch September 27, 2019 09:17
@jenshnielsen jenshnielsen mentioned this pull request Sep 27, 2019
Merged
@jenshnielsen jenshnielsen mentioned this pull request Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenshnielsen @astafan8