Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow missing types for instrument base and visa #1747

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Disallow missing types for instrument base and visa #1747

merged 3 commits into from
Oct 3, 2019

Conversation

jenshnielsen
Copy link
Collaborator

Since these are core parts of qcodes.

astafan8
astafan8 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward for the same strictness of parameters as well :)

@jenshnielsen
Copy link
Collaborator Author

@astafan8 Absolutely but one step at a time :)

@jenshnielsen jenshnielsen merged commit 9bf9494 into microsoft:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenshnielsen @astafan8