Driver keysight dmm time trace #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
=========================================
- Coverage 67.58% 67.5% -0.08%
=========================================
Files 146 146
Lines 18266 18320 +54
=========================================
+ Hits 12345 12367 +22
- Misses 5921 5953 +32 |
astafan8
reviewed
Oct 7, 2019
qcodes/instrument_drivers/Keysight/private/Keysight_344xxA_submodules.py
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/private/Keysight_344xxA_submodules.py
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/private/Keysight_344xxA_submodules.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/private/Keysight_344xxA_submodules.py
Outdated
Show resolved
Hide resolved
qcodes/instrument_drivers/Keysight/private/Keysight_344xxA_submodules.py
Show resolved
Hide resolved
WilliamHPNielsen
force-pushed
the
driver_keysight_dmm_time_trace
branch
from
4e1ec18
to
4dfc041
Compare
astafan8
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
timetraceparameter similar to the Keithley's recently added time trace parameter (#1684 ).Changes proposed in this pull request:
Allow instrument configuration to change(kicked off into seperate PR)voltparameterFor this PR to properly work, #1749 should be merged (a few of its commits live on this branch until then). Then this branch should be cleaned of the overlapping commits and rebased on master.Okay, that has happened now 馃檪