Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that get_latest will call get on a parameter #1751

Merged
merged 16 commits into from
Oct 8, 2019

Conversation

jenshnielsen
Copy link
Collaborator

If the parameter has never been captured it seems like get_latest should also call get

This is draft due to the missing tests

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #1751 into master will increase coverage by 0.02%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
+ Coverage    67.5%   67.52%   +0.02%     
==========================================
  Files         146      146              
  Lines       18320    18327       +7     
==========================================
+ Hits        12366    12376      +10     
+ Misses       5954     5951       -3

@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Oct 7, 2019

Todo

  • Test that get is called / not called when ts is not set / set
  • Test that error is raised when max_val_age is not None and get is not set
  • Test that get_latest raises when get is false and set / initial value is not called
  • Test that get_latest does not raise when get is false but set / initial value has been called

@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Oct 7, 2019

I uncovered a bug where max_val_age is never used in Parameter. Fixed and test added

@jenshnielsen jenshnielsen marked this pull request as ready for review October 7, 2019 14:56
@jenshnielsen
Copy link
Collaborator Author

@QCoDeS/core this is ready for review

qcodes/tests/test_parameter.py Show resolved Hide resolved
qcodes/tests/test_parameter.py Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen merged commit 38c7684 into microsoft:master Oct 8, 2019
@jenshnielsen jenshnielsen deleted the get_unknown_parameters branch October 8, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants