Dynacool add absolute tol parameter #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And set this to 5e-4 T by default
jenshnielsen
force-pushed
the
dynacool_add_tol
branch
from
2ac8869
to
de24fcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
=========================================
- Coverage 67.54% 67.45% -0.1%
=========================================
Files 146 146
Lines 18332 18263 -69
=========================================
- Hits 12383 12319 -64
+ Misses 5949 5944 -5 |
WilliamHPNielsen
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the default limit (1e-8) used in numpy all_close is too low. So set this to 5e-4 T which seems reasonable from the actual observed difference of 1-2e-4 T and make it configurable.
@WilliamHPNielsen Can you have a look
@GateBuilder If you have a chance can you test this at the actual setup