Set pytest directory to speed up test collection #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 67.56% 67.55% -0.01%
==========================================
Files 146 146
Lines 18343 18340 -3
==========================================
- Hits 12393 12390 -3
Misses 5950 5950 |
|
@jenshnielsen pinging because I added to restrict the file glob pattern. |
astafan8
reviewed
Oct 9, 2019
setup.cfg
Outdated
| [tool:pytest] | ||
| testpaths = "qcodes/tests" | ||
| python_files = test_*.py | ||
| python_functions = test_* |
There was a problem hiding this comment.
the python functions and python files entries - these are pytest defaults, right? do we really need to explicitly define them here?
There was a problem hiding this comment.
I wasn't 100% sure, how this was handled, but I read up on it: you are absolutely right. These are the defaults, which get overwritten individually when set. (only difference is python_function = test*, but we really don't care). So I will remove them again.
astafan8
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to speed up my local test collection.