Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AimTTi PL601-P Power Supply Driver #1763

Merged
merged 67 commits into from
Oct 21, 2019

Conversation

GateBuilder
Copy link
Contributor

This PR introduces the QCoDeS driver for the AimTTi PL601-P programmable power supply.

@WilliamHPNielsen

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1763 into master will decrease coverage by 0.13%.
The diff coverage is 47.54%.

@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
- Coverage   67.57%   67.44%   -0.14%     
==========================================
  Files         146      147       +1     
  Lines       18349    18471     +122     
==========================================
+ Hits        12400    12457      +57     
- Misses       5949     6014      +65

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some inline comments of varying importance.

I have one question about the step sizes: if I set the step size to, say, 0.5 V, what then happens if I set aim.volt(aim.volt() + 0.1)? I suspect that the setter for volt will have to handle this.

qcodes/tests/drivers/test_AimTTİ_PL601P.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
qcodes/tests/drivers/test_AimTTİ_PL601P.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AimTTi/AimTTi_PL601P_channels.py Outdated Show resolved Hide resolved
@GateBuilder
Copy link
Contributor Author

I have left some inline comments of varying importance.
I have one question about the step sizes: if I set the step size to, say, 0.5 V, what then happens if I set aim.volt(aim.volt() + 0.1)? I suspect that the setter for volt will have to handle this.

Yes, driver correctly handles this situation.

@WilliamHPNielsen
Copy link
Contributor

@GateBuilder would you mind revealing in some more detail what happens in the following case:
if I set the step size to, say, 0.5 V, what then happens if I set aim.volt(aim.volt() + 0.1) ?

@GateBuilder
Copy link
Contributor Author

@WilliamHPNielsen

would you mind revealing in some more detail what happens in the following case:
if I set the step size to, say, 0.5 V, what then happens if I set aim.volt(aim.volt() + 0.1) ?

Assume your current voltage is 0.5V. If you call aim.volt(aim.volt() + 0.1), then, if you get the voltage, your new value is 0.6V (which is what I have done with the actual instrument). In short, step size does not matter unless it is explicitly used.

@WilliamHPNielsen
Copy link
Contributor

@GateBuilder sweet! Thanks for explaining.

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

@WilliamHPNielsen WilliamHPNielsen merged commit ea3a6ed into microsoft:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants