-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AimTTi PL601-P Power Supply Driver #1763
AimTTi PL601-P Power Supply Driver #1763
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1763 +/- ##
==========================================
- Coverage 67.57% 67.44% -0.14%
==========================================
Files 146 147 +1
Lines 18349 18471 +122
==========================================
+ Hits 12400 12457 +57
- Misses 5949 6014 +65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some inline comments of varying importance.
I have one question about the step sizes: if I set the step size to, say, 0.5 V, what then happens if I set aim.volt(aim.volt() + 0.1)
? I suspect that the setter for volt
will have to handle this.
docs/examples/driver_examples/QCoDeS example with Aim TTi PL601-P.ipynb
Outdated
Show resolved
Hide resolved
Yes, driver correctly handles this situation. |
@GateBuilder would you mind revealing in some more detail what happens in the following case: |
Assume your current voltage is 0.5V. If you call aim.volt(aim.volt() + 0.1), then, if you get the voltage, your new value is 0.6V (which is what I have done with the actual instrument). In short, step size does not matter unless it is explicitly used. |
@GateBuilder sweet! Thanks for explaining. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in!
This PR introduces the QCoDeS driver for the AimTTi PL601-P programmable power supply.
@WilliamHPNielsen