Add types to all of parameter #1769
Conversation
There are a number of less than idea issues here that makes it tricky
| def __exit__(self, typ, value, traceback): | ||
| def __exit__(self, typ, # type: ignore[no-untyped-def] | ||
| value, | ||
| traceback) -> None: |
There was a problem hiding this comment.
We could type this as given in https://github.com/python/typeshed/blob/master/stdlib/2and3/contextlib.pyi#L23 and https://github.com/python/typeshed/blob/master/stdlib/3/types.pyi#L235 but that does not seem all that useful. If there was a nice way to get these types from the typeshead without re implementing that would help
And remove redundant types from docstrings
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
- Coverage 67.44% 67.44% -0.01%
==========================================
Files 147 147
Lines 18471 18486 +15
==========================================
+ Hits 12457 12467 +10
- Misses 6014 6019 +5 |
| def __exit__(self, typ, value, traceback): | ||
| def __exit__(self, typ, # type: ignore[no-untyped-def] | ||
| value, | ||
| traceback) -> None: |
| @@ -2075,40 +2132,48 @@ def _multiplier(self, multiplier: Union[int, float, Parameter]): | |||
|
|
|||
| # Division of the scaler | |||
| @property | |||
| def division(self): | |||
| def division(self) -> float: # type: ignore[return] | |||
There was a problem hiding this comment.
why ignore return if the type is specified via casting? or am i misunderstanding something?
There was a problem hiding this comment.
Due to the mypy bug mentioned above. Remember that unused ignores is an error, so you can be sure this is needed anyway
There was a problem hiding this comment.
That is if mypy ever resolves the bug this will be an error and all to do is to remove this ignore comment
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
There are a number of less than idea issues here that makes it tricky and requires workarounds