-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example notebooks: Context Manager, Dataset Performance and Extract Runs #1777
Fix example notebooks: Context Manager, Dataset Performance and Extract Runs #1777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
- Coverage 67.44% 67.43% -0.01%
==========================================
Files 147 147
Lines 18487 18487
==========================================
- Hits 12468 12467 -1
- Misses 6019 6020 +1 |
docs/examples/DataSet/Extracting-runs-from-one-DB-file-to-another.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def get_list_of_first_param(results_list, lenght, state):
The spelling of length can be corrected. This is in section 'Subscription example 2: using the state' Sorry, I could not review at the exact location since file is not rendering.
docs/examples/DataSet/Extracting-runs-from-one-DB-file-to-another.ipynb
Outdated
Show resolved
Hide resolved
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
…her.ipynb Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
2d148d4
to
510235e
Compare
…her.ipynb Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last fix and lets merge!
This PR proposes some fixes to the example notebooks:
@Dominik-Vogel