Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example notebooks: Context Manager, Dataset Performance and Extract Runs #1777

Merged
merged 17 commits into from
Oct 25, 2019

Conversation

GateBuilder
Copy link
Contributor

This PR proposes some fixes to the example notebooks:

  • The Context Manager
  • Dataset Performance
  • Extracting runs from one DB file to another

@Dominik-Vogel

@GateBuilder GateBuilder added the docs Related to docs improvements label Oct 21, 2019
@GateBuilder GateBuilder changed the title Fix notebook w2 1 Fix example notebooks: Context Manager, Dataset Performance and Extract Runs Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #1777 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
- Coverage   67.44%   67.43%   -0.01%     
==========================================
  Files         147      147              
  Lines       18487    18487              
==========================================
- Hits        12468    12467       -1     
- Misses       6019     6020       +1

Copy link
Contributor

@lakhotiaharshit lakhotiaharshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def get_list_of_first_param(results_list, lenght, state):

The spelling of length can be corrected. This is in section 'Subscription example 2: using the state' Sorry, I could not review at the exact location since file is not rendering.

@GateBuilder GateBuilder force-pushed the fix_notebook_w2_1 branch 2 times, most recently from 2d148d4 to 510235e Compare October 25, 2019 12:07
…her.ipynb

Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last fix and lets merge!

docs/examples/DataSet/Dataset Context Manager.ipynb Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen merged commit 754fd42 into microsoft:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants