-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example notebooks in section Parameter
of Example of using Qcodes
#1780
Fix example notebooks in section Parameter
of Example of using Qcodes
#1780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
docs/examples/Parameters/Simple-Example-of-ParameterWithSetpoints.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/Parameters/Simple-Example-of-ParameterWithSetpoints.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/Parameters/Simple-Example-of-ParameterWithSetpoints.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/Parameters/Simple-Example-of-ParameterWithSetpoints.ipynb
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
+ Coverage 69.71% 69.71% +<.01%
==========================================
Files 148 148
Lines 18572 18572
==========================================
+ Hits 12947 12948 +1
+ Misses 5625 5624 -1 |
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
…atabase_at Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please correct these links to be direct ipynb links
Fixes the notebooks related to Parameters. Apart from fixing typing errors, the following important corrections are done:
setpoints
@astafan8 @GateBuilder