Avoid getting raw_value attribute of parameters in SR830 and partially Alazar #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed for the following parameters: - external_sample_rate - sample_rate - buffers_per_acquisition - samples_per_record - records_per_buffer - allocated_buffers - buffers_per_acquisition - buffer_timeout
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #1788 +/- ##
=======================================
Coverage 69.82% 69.82%
=======================================
Files 149 149
Lines 18666 18666
=======================================
Hits 13033 13033
Misses 5633 5633 |
…bute-of-parameter
astafan8
changed the title
…bute-of-parameter
…bute-of-parameter
…bute-of-parameter
…bute-of-parameter
…bute-of-parameter
Dominik-Vogel
approved these changes
Nov 7, 2019
| @@ -572,12 +572,16 @@ def decrement_sensitivity(self): | |||
| return self._change_sensitivity(-1) | |||
|
|
|||
| def _change_sensitivity(self, dn): | |||
| _ = self.sensitivity.get() | |||
| n = int(self.sensitivity.raw_value) | |||
| sensitivity = self.sensitivity.get() | |||
There was a problem hiding this comment.
Is there any reason why you are using the explicit .get() here? I think we could inline this call and remove the variable.
There was a problem hiding this comment.
no reason really. let me inline, shoud still be readable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it is to be deprecated and a new API is to be used (likely,
parameter.get_cache_raw()).Drivers altered:
Won't do in this PR:
raw_valueof a parameter is needed. Sinceraw_valueis not yet deprecated and is used only for "getting" the raw value, then let's keep it for now. In the future, gettingraw_valueshould probably subsituted with new API that i introduced here Add get_raw_value to GetLatest of Parameter #1787 .