Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of _save_val in drivers and core qcodes #1790

Conversation

astafan8
Copy link
Contributor

... via set_cache or other fixes.

Requires merge of #1757.

Note: Keysight B1500 use of _save_val is fixed in #1789.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1790 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1790      +/-   ##
==========================================
- Coverage   67.48%   67.48%   -0.01%     
==========================================
  Files         147      147              
  Lines       18511    18508       -3     
==========================================
- Hits        12493    12490       -3     
  Misses       6018     6018

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me

@astafan8 astafan8 merged commit e605620 into microsoft:master Oct 28, 2019
@astafan8 astafan8 deleted the use-set-cache-or-else-iso-save-val-of-parameter branch October 28, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants