-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of _save_val in drivers and core qcodes #1790
Merged
astafan8
merged 15 commits into
microsoft:master
from
astafan8:use-set-cache-or-else-iso-save-val-of-parameter
Oct 28, 2019
Merged
Remove usage of _save_val in drivers and core qcodes #1790
astafan8
merged 15 commits into
microsoft:master
from
astafan8:use-set-cache-or-else-iso-save-val-of-parameter
Oct 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
- Coverage 67.48% 67.48% -0.01%
==========================================
Files 147 147
Lines 18511 18508 -3
==========================================
- Hits 12493 12490 -3
Misses 6018 6018 |
jenshnielsen
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... via
set_cache
or other fixes.Requires merge of #1757.
Note: Keysight B1500 use of
_save_val
is fixed in #1789.