Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Codacy from file to reproduce same error messages locally #1804

Merged
merged 7 commits into from
Nov 4, 2019

Conversation

Dominik-Vogel
Copy link
Contributor

Currently the only python complaints raised by codacy stem from pylint. The standard config of pylint is massively tweaked via a filter set in the codacy ui. In this PR I went through some painful regexps to convert the html of the config page to a useful .pylintrc file.

This file can be used instead of the UI by codacy, but it can also be used by running pylint locally.

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #1804 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1804   +/-   ##
=======================================
  Coverage   69.75%   69.75%           
=======================================
  Files         148      148           
  Lines       18610    18610           
=======================================
  Hits        12982    12982           
  Misses       5628     5628

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 We should investigate why codacy is not running on this branch

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that looks like a big work! Big thanks, Dominik! I went through it quickly assuming that this is a port of current codacy settings (i think in the future we might want to remove quite a few of entries from disable section :) )

@Dominik-Vogel
Copy link
Contributor Author

please Mikhail, remove some disable settings. I started with the original settings and already removed some, of which I thought they were purely beneficial to remove.
(TBH, the work was not so big, thanks to regexp)

@jenshnielsen jenshnielsen merged commit e2aeb79 into microsoft:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants