Add types to sqlite queries #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
=======================================
Coverage 69.78% 69.78%
=======================================
Files 149 149
Lines 18656 18656
=======================================
Hits 13019 13019
Misses 5637 5637 |
astafan8
approved these changes
Nov 7, 2019
| source_conn = connect(source_db_path) | ||
|
|
||
| # Validate that all runs are in the source database | ||
| do_runs_exist = is_run_id_in_database(source_conn, run_ids) | ||
| do_runs_exist = is_run_id_in_database(source_conn, *run_ids) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uncovers an actual bug in in database extract runs that was not correctly unpacking the run_ids.
This bug happened to not matter since numpy.unique flattens nested arrays such that
[[1,2,3,3]] -> np.ndarray([1,2,3])and was therefore not caught by tests