Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type all of qcodes.dataset.* #1815

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Nov 8, 2019

@jenshnielsen please feel free to improve this as you deem needed (and push to this branch).

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #1815 into master will decrease coverage by <.01%.
The diff coverage is 91.11%.

@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
- Coverage   69.82%   69.81%   -0.01%     
==========================================
  Files         149      149              
  Lines       18666    18670       +4     
==========================================
+ Hits        13033    13035       +2     
- Misses       5633     5635       +2

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, At some point we should probably try to get rid of some more of the Anys but that can wait

@astafan8 astafan8 merged commit 46d8141 into microsoft:master Nov 8, 2019
@astafan8 astafan8 deleted the type-dataset branch November 8, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants