-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type all of qcodes.instrument.* except .mockers.ami430 #1817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
- Coverage 70.27% 70.24% -0.04%
==========================================
Files 148 148
Lines 18572 18589 +17
==========================================
+ Hits 13051 13057 +6
- Misses 5521 5532 +11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. There is scope to reduce some of the Any to something more specific
It looks like @Dominik-Vogel is right
Type checks correctly for int and float but not for complex |
And for a bit more fun
with https://github.com/numpy/numpy-stubs installed as of master today.
|
This looks good. Only remaining point is to change all new Union[float,int] to float |
@jenshnielsen feel free to push to this branch/PR if necessary.