Make InstrumentBase name and short_name read-only properties #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penQutech/Qcodes into feature/instrument_name
Codecov Report
@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
+ Coverage 70.25% 70.26% +<.01%
==========================================
Files 148 148
Lines 18557 18563 +6
==========================================
+ Hits 13038 13044 +6
Misses 5519 5519 |
jenshnielsen
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the InstrumentBase.name and InstrumentBase.short_name read-only because those are not supposed to be changed after instrument instantiation.
Since this is a breaking change, this PR also contains an addition to 0.8.0 release changelog.
Duplicates and closes #1731.