Implement cache for DelegateParameter to mirror cache of the source parameter #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominik-Vogel
force-pushed
the
DelegateParameterCache
branch
from
12bf444
to
668a511
Compare
|
@Dominik-Vogel could you please rebase this PR on top of #1832 ? |
Dominik-Vogel
force-pushed
the
DelegateParameterCache
branch
from
3b4631f
to
3212aac
Compare
|
done |
Dominik-Vogel
force-pushed
the
DelegateParameterCache
branch
from
3212aac
to
df3daf4
Compare
|
(Rebased onto wrong branch, really sorry, I lost the overview over all the different cache PRs) |
astafan8
reviewed
Nov 21, 2019
... to make sense
ideally common interface should be factored out
astafan8
force-pushed
the
DelegateParameterCache
branch
from
eb19a6d
to
1dbe501
Compare
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
+ Coverage 70.28% 70.31% +0.03%
==========================================
Files 148 148
Lines 18621 18648 +27
==========================================
+ Hits 13087 13113 +26
- Misses 5534 5535 +1 |
|
@Dominik-Vogel I merged the master with the |
astafan8
changed the title
astafan8
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
I think this is good to go. @Dominik-Vogel please also confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements cache of
DelegateParameterto exactly mirror the cache of the source parameter. Depends on #1832.For now, some dirty stuff with respect to accessing
_valueof cache is needed, but this wouldn't be necessary whensnapshot_baseimprovements will be worked on in #1833.Fixes #1782.