Unify default values of arguments for all snapshot_base and snapshot methods in qcodes repo #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
=======================================
Coverage 70.37% 70.37%
=======================================
Files 152 152
Lines 18859 18859
=======================================
Hits 13272 13272
Misses 5587 5587 |
|
@jenshnielsen @Dominik-Vogel what do you think about this PR? also about the question in the description? |
... because these are all overrides of the Metadatable.snapshot_base method, hence the default values should (probably) be the same.
... because these are all overrides of the Metadatable.snapshot method, hence the default values should (probably) be the same.
astafan8
force-pushed
the
unify-snapshot-base-signature
branch
from
1c2face
to
11c51dc
Compare
|
I need a bit of time to reevaluate the chaining before I can make my mind of if this |
|
closing in favor of #4808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To promote "the same" behavior unless needed explicitly. (i think that it's good, but if there are use cases against that i'm happy to hear about those here)
Note that right before merging the commits in this PR will be rebased on the lastest master for a cleaner history :)
Places in question:
the
ZIHDAWG8driver - does anyone remember why is this override needed? how is this instrument special to all the other instruments?