Fix error created on logging station config validation #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
==========================================
+ Coverage 70.37% 70.38% +<.01%
==========================================
Files 152 152
Lines 18847 18852 +5
==========================================
+ Hits 13264 13269 +5
Misses 5583 5583 |
astafan8
approved these changes
Nov 27, 2019
Dominik-Vogel
added a commit
that referenced
this pull request
Nov 28, 2019
Fix error created on logging station config validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been an error appending the station config files to the log messages if the station config validation has not been successful.
This error has not been caught by the tests, because it is specific to handling real station config files, while the tests work with simple strings.
A test has been added for this edge case.
@QCoDeS/core hotfix for v0.8.1