Run pip with --no-index in installation_info #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 70.37% 70.38% +<.01%
==========================================
Files 152 152
Lines 18852 18852
==========================================
+ Hits 13268 13269 +1
+ Misses 5584 5583 -1 |
jenshnielsen
approved these changes
Nov 28, 2019
|
but please fix the style issue pointed out by codacy |
|
Done. I made it True instead of the default False to catch errors more clearly. E: I actually missed the style issue you were referring to, fixed now. Should I revert cf61ecf or is it okay? |
|
Thanks, I think check=True is good no need to revert anything |
Merged
Dominik-Vogel
pushed a commit
that referenced
this pull request
Nov 28, 2019
Run pip with --no-index in installation_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running Qcodes on a lab computer with no internet access. Running
pip listlooks online for the package index. This takes 20 seconds to time out, which makesstart_all_logging()annoyingly slow. This fixes that.