add electrical delay parameter and function set_electrical_delay_auto for ZNB driver #1849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameter 'electrical_delay' to rohde_schwarz/ZNB driver.
Allows to get and set the electrical delay to de-embed the cabel length from the phase signal.
The electrical delay will be added to port2, this is currently hardcoded. When autosetting on the softbuttons on the physical instrument, this seems to be the default option. Also, it does not make a difference (as far as we can see) for the signal.
Added function 'set_electrical_delay_auto'. This function automatically sets the electrical delay to the active port. A wide frequency span during execution of the function leads to more accurate results.
Changes proposed in this pull request:
@astafan8 @lakhotiaharshit