Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add electrical delay parameter and function set_electrical_delay_auto for ZNB driver #1849

Conversation

LGruenhaupt
Copy link
Contributor

Added parameter 'electrical_delay' to rohde_schwarz/ZNB driver.
Allows to get and set the electrical delay to de-embed the cabel length from the phase signal.
The electrical delay will be added to port2, this is currently hardcoded. When autosetting on the softbuttons on the physical instrument, this seems to be the default option. Also, it does not make a difference (as far as we can see) for the signal.

Added function 'set_electrical_delay_auto'. This function automatically sets the electrical delay to the active port. A wide frequency span during execution of the function leads to more accurate results.

Changes proposed in this pull request:

  • add parameter electrical_delay in rohde_schwarz/ZNB.py
  • add function set_electrical_delay_auto in rohde_schwarz/ZNB.py

@astafan8 @lakhotiaharshit

…A, at the moment hardcoded. add function set_electrical_delay_auto
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #1849 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1849   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files         152      152           
  Lines       18864    18864           
=======================================
  Hits        13275    13275           
  Misses       5589     5589

@astafan8 astafan8 merged commit 4524e58 into microsoft:master Nov 29, 2019
@LGruenhaupt LGruenhaupt deleted the feature/ZNB20_add_electrical_delay_and_autoset branch December 5, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants