Unique name for instrument logger

[jenshnielsen]

This ensures that each instrument will have it's own logger so that messages can easily be filtered by instrument instance

An instrument will have a logger with a name of the form module.path.to.instrument.classname-instancename
and in the same way a channel will have a logger with a name of the form module.path.to.instrument.classname-instancename.channelclassname-channelinstancename

@Dominik-Vogel

[jenshnielsen]

If we go that way there should be some tests added

[codecov]

Codecov Report

Merging #1914 into master will decrease coverage by 0.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
- Coverage   68.92%   68.14%   -0.78%     
==========================================
  Files         156      156              
  Lines       19924    19929       +5     
==========================================
- Hits        13732    13581     -151     
- Misses       6192     6348     +156     

[astafan8]

this sounds like a good idea, especially since instrument loggers are per-instance.

and tests - yes :) i suggest just simple ones - actual name of the instrument logger and channel logger.

[jenshnielsen]

This is now replaced by #5297 which will ensure that the instrument_name is an extra attribute on the logrecord from the instrument LoggerAdapter