Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert helpers tests to pytest style and break up into individual files #2235

Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Oct 3, 2020

And integrate the json tests from test helpers with the onces from test_json

@jenshnielsen jenshnielsen changed the title convert helpers tests pytest style and break up into individual files convert helpers tests to pytest style and break up into individual files Oct 4, 2020
@jenshnielsen jenshnielsen force-pushed the cleanup/unittest_to_pytest_helpers branch from ac35469 to 4faa477 Compare October 4, 2020 05:08
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #2235 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   71.76%   71.77%           
=======================================
  Files         153      153           
  Lines       20515    20515           
=======================================
+ Hits        14723    14724    +1     
+ Misses       5792     5791    -1     

qcodes/tests/helpers/test_strip_atters.py Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen force-pushed the cleanup/unittest_to_pytest_helpers branch from 488fe3d to 96e685a Compare October 5, 2020 12:07
@jenshnielsen jenshnielsen merged commit 99b86b4 into microsoft:master Oct 5, 2020
@jenshnielsen jenshnielsen deleted the cleanup/unittest_to_pytest_helpers branch October 5, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants