-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating doNd notebook with comparing Measurement context manager with qcodes doNd #2512
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2512 +/- ##
==========================================
+ Coverage 62.30% 63.60% +1.29%
==========================================
Files 200 198 -2
Lines 26412 25929 -483
==========================================
+ Hits 16457 16493 +36
+ Misses 9955 9436 -519 |
...t/Deeper dive on qcodes doNd functionalities with a focus on arrayed sweeping benefits.ipynb
Outdated
Show resolved
Hide resolved
...t/Deeper dive on qcodes doNd functionalities with a focus on arrayed sweeping benefits.ipynb
Outdated
Show resolved
Hide resolved
...t/Deeper dive on qcodes doNd functionalities with a focus on arrayed sweeping benefits.ipynb
Outdated
Show resolved
Hide resolved
...t/Deeper dive on qcodes doNd functionalities with a focus on arrayed sweeping benefits.ipynb
Outdated
Show resolved
Hide resolved
...t/Deeper dive on qcodes doNd functionalities with a focus on arrayed sweeping benefits.ipynb
Outdated
Show resolved
Hide resolved
...t/Deeper dive on qcodes doNd functionalities with a focus on arrayed sweeping benefits.ipynb
Outdated
Show resolved
Hide resolved
Could you look at the modifications of the notebook. If you think, it is acceptable in its current form, we can have it in the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaurement took 41.3532292842865 seconds
- this is too long. Can we reduce this to ~seconds while still making a point? do we even need the sleep() calls now that "timings of buffered aquisition" is not in scope?
This is the minimum sleep. I kept this because earlier in the notebook, I promoted using plottr to see the live plot. For having that, We need sleep time. One thing that I can do is to give the sleep for the outer loop. Then It takes 5 to 6 seconds. |
...amples/DataSet/Comparing qcodes Measurement context manager with qcodes doNd functions.ipynb
Outdated
Show resolved
Hide resolved
@jenshnielsen |
I am a bit confused as how this compares to the existing dond notebook. There seems to be a lot of duplicated content. Perhaps it is better to extend that notebook to explain how the experiments in that notebook can be done using the existing measurement framwork? |
The modified version of this notebook caused this duplication. In the current format of this notebook, It's reasonable to extend the other notebook with Measurement comparison. It might need an updated title such as : Using doNd functions in comparison to Measurement for performing measurements or something similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline. The overall structure is good but we need to work a bit on the writing
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/DataSet/Using_the_doNd_functions_for_running_experiments.ipynb
Outdated
Show resolved
Hide resolved
After some back and forth, we decided to improve the already existed doNd notebook with comparing doNds with Measurement instead of creating a new notebook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! and the execution time of the whole notebook is on the order of 1-2 seconds, right?
The execution time may be about 15 seconds for the whole notebook. |
This PR compares two things in 4 sections:
Comparing 1D and 2D sweeps when z parameter depends on x and y parameters sweeps (This is not the goal of this PR anymore)
Comparing the use of Measurement context manager with qcodes doNd.
Update: After careful consideration, it is decided to extend this existing notebook with the content of Measurement.