Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating doNd notebook with comparing Measurement context manager with qcodes doNd #2512

Merged
merged 19 commits into from
Jan 12, 2021

Conversation

FarBo
Copy link
Contributor

@FarBo FarBo commented Dec 10, 2020

This PR compares two things in 4 sections:
Comparing 1D and 2D sweeps when z parameter depends on x and y parameters sweeps (This is not the goal of this PR anymore)
Comparing the use of Measurement context manager with qcodes doNd.

Update: After careful consideration, it is decided to extend this existing notebook with the content of Measurement.

@FarBo FarBo added the docs Related to docs improvements label Dec 10, 2020
@FarBo FarBo added this to the 0.21.0 milestone Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #2512 (fc3d9d3) into master (0074889) will increase coverage by 1.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
+ Coverage   62.30%   63.60%   +1.29%     
==========================================
  Files         200      198       -2     
  Lines       26412    25929     -483     
==========================================
+ Hits        16457    16493      +36     
+ Misses       9955     9436     -519     

@FarBo FarBo changed the title A notebook for comparing qcodes doNd and measurement, as well as 1D and 2D sweeps. Comparing qcodes Measurement context manager with qcodes doNd functions Dec 15, 2020
@FarBo
Copy link
Contributor Author

FarBo commented Dec 16, 2020

@jenshnielsen
@astafan8

Could you look at the modifications of the notebook. If you think, it is acceptable in its current form, we can have it in the release.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaurement took 41.3532292842865 seconds - this is too long. Can we reduce this to ~seconds while still making a point? do we even need the sleep() calls now that "timings of buffered aquisition" is not in scope?

@FarBo
Copy link
Contributor Author

FarBo commented Dec 16, 2020

this is too long.

This is the minimum sleep. I kept this because earlier in the notebook, I promoted using plottr to see the live plot. For having that, We need sleep time. One thing that I can do is to give the sleep for the outer loop. Then It takes 5 to 6 seconds.

@FarBo FarBo modified the milestones: 0.21.0, 0.22.0 Dec 17, 2020
@FarBo
Copy link
Contributor Author

FarBo commented Dec 18, 2020

@jenshnielsen
My bad not setting the conversations resolved. Thanks for reminding it. I think all comments have been addressed now, hopefully :).

@jenshnielsen
Copy link
Collaborator

I am a bit confused as how this compares to the existing dond notebook. There seems to be a lot of duplicated content. Perhaps it is better to extend that notebook to explain how the experiments in that notebook can be done using the existing measurement framwork?

@FarBo
Copy link
Contributor Author

FarBo commented Dec 22, 2020

The modified version of this notebook caused this duplication. In the current format of this notebook, It's reasonable to extend the other notebook with Measurement comparison. It might need an updated title such as : Using doNd functions in comparison to Measurement for performing measurements or something similar.

@FarBo FarBo changed the title Comparing qcodes Measurement context manager with qcodes doNd functions Updating doNd notebook with comparing Measurement context manager with qcodes doNd Dec 22, 2020
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline. The overall structure is good but we need to work a bit on the writing

@FarBo
Copy link
Contributor Author

FarBo commented Jan 8, 2021

@jenshnielsen
@astafan8

After some back and forth, we decided to improve the already existed doNd notebook with comparing doNds with Measurement instead of creating a new notebook.
I think Jens already reviewed it. So, you may have a look (hopefully the final one :) ).

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! and the execution time of the whole notebook is on the order of 1-2 seconds, right?

@FarBo
Copy link
Contributor Author

FarBo commented Jan 8, 2021

The execution time may be about 15 seconds for the whole notebook.

@jenshnielsen jenshnielsen merged commit 48d8bcc into microsoft:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants