Remove deprecated SD_common module #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
remove_sdcommon
branch
from
fb7dd6e
to
2632472
Compare
Codecov Report
@@ Coverage Diff @@
## master #2544 +/- ##
==========================================
+ Coverage 62.37% 63.60% +1.23%
==========================================
Files 201 198 -3
Lines 26445 25912 -533
==========================================
- Hits 16494 16481 -13
+ Misses 9951 9431 -520 |
astafan8
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module has moved to qcodes_contrib_drivers along with the drivers that use it.
This has been unused inside qcodes for a while but only deprecated since 0.20
A test was found that uses the module. This has been ported to contrib drivers too via QCoDeS/Qcodes_contrib_drivers#87