Slightly more flexible type check #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct[str, StepOutputDict]; expected Mapping[Hashable, Any] by making the arguments typevars with the correct bound
jenshnielsen
force-pushed
the
more_flexlible_typing_of_deep_update
branch
from
1b7f1e7
to
d5744f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2546 +/- ##
=======================================
Coverage 63.60% 63.60%
=======================================
Files 198 198
Lines 25912 25915 +3
=======================================
+ Hits 16481 16484 +3
Misses 9431 9431 |
astafan8
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issues such as
Argument 2 to deep_update has incompatible type Dict[str, StepOutputDict]; expected Mapping[Hashable, Any]by making the arguments typevars with the correct bound