Add drivers for Keysight PXIE devices, M960X and M9336A #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 14, 2021 08:45
These definitions come straight out of the IVI-C header file from Keysight, KtM960x.h. They've been crudely converted from C++ hash defines into python constants.
Add initial driver support for the KtM960x. This wraps the IVI-C dll with ctypes to support some basic parameters.
This is a basic set of parameters including a measurement function to set up a output voltage anad measure a current.
Add the attributes and definitions from the KtMAwg.h header file from Keysight.
This opens the KtMAwg.dll and reads out the information and serial number from the driver.
Need to create a instr_channel class here.
Still need to split this into channel drivers, but this runs in the simulator without errors.
Adds a channel list to the driver for the 3 channels. Add a few parameters to control the gain
Akshita07
reviewed
Feb 18, 2021
astafan8
reviewed
Feb 18, 2021
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
+ Coverage 63.88% 64.85% +0.97%
==========================================
Files 199 203 +4
Lines 26516 27840 +1324
==========================================
+ Hits 16939 18056 +1117
- Misses 9577 9784 +207 |
Update validators for gain and SMU parameters.
…setters in KtM960x
…setters in KtMAwg
jenshnielsen
approved these changes
Feb 26, 2021
|
@Akshita07 please update the imports and we can get it in |
|
Thanks for the help here guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
looking for feedback on these proposed drivers. I wrote them to support our testing efforts here in Sydney but they rely on wrapping the IVI-C .dll's from Keysight, so I'm not sure where the best place to commit them too is.
Included in the branch are two 'definition' files which are crude translations of the IVI-C c++ header files into something Python can interpret. These are necessary for all the magic numbers the .dll's expect.
Changes proposed in this pull request:
https://www.keysight.com/main/software.jspx?ckey=3085523&lc=eng&cc=HK&nid=-11143.0.00&id=3085523
https://www.keysight.com/en/pd-2757436-pn-M9336A/pxie-i-q-arbitrary-waveform-generator-16-bit-540-mhz-3-scalar-channels?nid=-33321.1201965&cc=AU&lc=eng
@WilliamHPNielsen