Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit data directy to dataset cache #2667

Merged
merged 43 commits into from
Feb 8, 2021

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jan 28, 2021

No description provided.

@jenshnielsen jenshnielsen force-pushed the live_cache branch 8 times, most recently from f8dbfac to 87a1821 Compare February 2, 2021 14:16
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #2667 (3ec8917) into master (80179e6) will increase coverage by 0.07%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #2667      +/-   ##
==========================================
+ Coverage   63.71%   63.79%   +0.07%     
==========================================
  Files         198      198              
  Lines       26376    26438      +62     
==========================================
+ Hits        16805    16865      +60     
- Misses       9571     9573       +2     

@jenshnielsen jenshnielsen force-pushed the live_cache branch 3 times, most recently from 63687ed to cefe0fb Compare February 4, 2021 12:33
@jenshnielsen jenshnielsen marked this pull request as ready for review February 4, 2021 13:18
qcodes/dataset/data_set.py Show resolved Hide resolved
qcodes/dataset/data_set.py Outdated Show resolved Hide resolved
qcodes/dataset/data_set.py Outdated Show resolved Hide resolved
qcodes/dataset/data_set.py Show resolved Hide resolved
qcodes/dataset/data_set.py Show resolved Hide resolved
qcodes/dataset/descriptions/detect_shapes.py Show resolved Hide resolved
qcodes/dataset/measurements.py Outdated Show resolved Hide resolved
qcodes/dataset/measurements.py Show resolved Hide resolved
qcodes/tests/dataset/test_data_set_cache.py Outdated Show resolved Hide resolved
qcodes/tests/dataset/test_data_set_cache.py Outdated Show resolved Hide resolved
@jenshnielsen
Copy link
Collaborator Author

@astafan8 I think all the issues should be addressed

@jenshnielsen jenshnielsen merged commit 6580e92 into microsoft:master Feb 8, 2021
@jenshnielsen jenshnielsen deleted the live_cache branch February 8, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants