automatic validator for agilent E8527D based on options #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
- Coverage 63.77% 63.71% -0.06%
==========================================
Files 198 198
Lines 26350 26376 +26
==========================================
+ Hits 16804 16805 +1
- Misses 9546 9571 +25 |
jenshnielsen
reviewed
Feb 4, 2021
|
@simonzihlmann thanks apart from the one comment this looks good. You will also need to re add the new line at the end of the file to make the CI happy |
jenshnielsen
reviewed
Feb 4, 2021
jenshnielsen
reviewed
Feb 5, 2021
jenshnielsen
reviewed
Feb 5, 2021
jenshnielsen
approved these changes
Feb 5, 2021
simonzihlmann
deleted the
feat/automatic_validators_for_Agilent_E8527D
branch
trevormorgan
added a commit
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
-determine the validators for the frequency and power parameter of the Agilent E8527D microwave source based on the installed options.
@jenshnielsen