Guid-helpers: Use ast instead of regex #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2700 +/- ##
=======================================
Coverage 63.83% 63.84%
=======================================
Files 198 198
Lines 26470 26487 +17
=======================================
+ Hits 16898 16911 +13
- Misses 9572 9576 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression used to read guids from a string represantation of a list/tuple of guids was flawed and managed to sneak around the test, by working on 0, 1, and 2 guids.
In this PR I am using the
ast.parseinstead, which makes it a lot easier and error proof.Thanks @astafan8 !